-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
In generate-screenshots
workflow, use commit action for generating signing commits
#8683
Open
angusbayley
wants to merge
3
commits into
develop
Choose a base branch
from
support/signed-screenshot-gh-commits-swinton
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 4 Skipped Deployments
|
angusbayley
changed the title
Support/signed screenshot gh commits swinton
[Experimental] Generate screenshots, use swinton for signing commits
Dec 13, 2024
angusbayley
force-pushed
the
support/signed-screenshot-gh-commits-swinton
branch
from
December 16, 2024 16:03
4445fae
to
4a4f0a2
Compare
live-github-bot
bot
added
automation
CI/CD stuff
screenshots
Screenshots have been updated
and removed
screenshots
Screenshots have been updated
labels
Dec 16, 2024
angusbayley
force-pushed
the
support/signed-screenshot-gh-commits-swinton
branch
from
December 16, 2024 16:21
9d16423
to
e792d4b
Compare
There as been no activity on this PR for the last 14 days. Please consider closing this PR. |
angusbayley
force-pushed
the
support/signed-screenshot-gh-commits-swinton
branch
from
January 2, 2025 18:07
4333726
to
c807106
Compare
angusbayley
force-pushed
the
support/signed-screenshot-gh-commits-swinton
branch
5 times, most recently
from
January 6, 2025 10:04
2416902
to
d4fa67a
Compare
angusbayley
force-pushed
the
support/signed-screenshot-gh-commits-swinton
branch
from
January 6, 2025 10:05
d4fa67a
to
f3e5116
Compare
angusbayley
force-pushed
the
support/signed-screenshot-gh-commits-swinton
branch
from
January 6, 2025 10:08
a3b7bcf
to
6b6e751
Compare
angusbayley
changed the title
[Experimental] Generate screenshots, use swinton for signing commits
Generate screenshots, use commit action for generating signing commits
Jan 6, 2025
angusbayley
changed the title
Generate screenshots, use commit action for generating signing commits
In Jan 6, 2025
generate-screenshots
workflow, use commit action for generating signing commits
themooneer
approved these changes
Jan 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket here
Uses the ghcommit action to make a verified commit for the generated screenshots.
In this PR we replace our manual git commands for creating a commit with the ghcommit action, which makes a request to the Github API to create a commit instead. In this PR we use that action, but provide the
GITHUB_TOKEN
to authenticate the request. TheGITHUB_TOKEN
is locally scoped to just that workflow run (i.e. short lived), and is generated by Github. When Github receives the request it parses theGITHUB_TOKEN
and recognises the commit as originating from the repo's own actions, marking it as Verified on this basis. Verification that the commit is generated within the repo's actions is sufficient because 3rd parties (people outside the Ledger organisation) cannot initiate agenerate-screenshots
run.Test PR for this is #8806, with the workflow run here. 🟢, commit generated and verified ✅
During this work 2 other approaches were tried
[
and]
characters, which GPG does not recognise as valid characters in an email address