Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support/enable broadcast on demand v2 #8706

Merged
merged 8 commits into from
Dec 18, 2024

Conversation

ypolishchuk-ledger
Copy link
Contributor

@ypolishchuk-ledger ypolishchuk-ledger commented Dec 16, 2024

Allure report: https://ledger-live.allure.green.ledgerlabs.net/allure/reports/fe0a70fb-6324-4414-aaa5-3b3f8c171122/#suites/ef5bf13c228385cbbaaa68dc2d53184b/c12d02da795f0305/

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

📝 Description

Replace this text by a clear and concise description of what this pull request is about and why it is needed. Be sure to explain the problem you're addressing and the solution you're proposing.
For libraries, you can add a code sample of how to use it.
For bug fixes, you can explain the previous behaviour and how it was fixed.
In case of visual features, please attach screenshots or video recordings to demonstrate the changes.

❓ Context

  • JIRA or GitHub link:

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@ypolishchuk-ledger ypolishchuk-ledger requested review from a team as code owners December 16, 2024 16:35
Copy link

vercel bot commented Dec 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Dec 18, 2024 1:49pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Dec 18, 2024 1:49pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Dec 18, 2024 1:49pm
web-tools ⬜️ Ignored (Inspect) Visit Preview Dec 18, 2024 1:49pm

@live-github-bot live-github-bot bot added desktop Has changes in LLD automation CI/CD stuff labels Dec 16, 2024
@ypolishchuk-ledger ypolishchuk-ledger force-pushed the support/enable-broadcast-on-demand-v2 branch from 1cf1a4d to fea5b35 Compare December 17, 2024 15:13
VicAlbr
VicAlbr previously approved these changes Dec 17, 2024
Copy link
Contributor

@abdurrahman-ledger abdurrahman-ledger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ypolishchuk-ledger ypolishchuk-ledger merged commit a09eb3f into develop Dec 18, 2024
40 of 41 checks passed
@ypolishchuk-ledger ypolishchuk-ledger deleted the support/enable-broadcast-on-demand-v2 branch December 18, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation CI/CD stuff desktop Has changes in LLD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants