Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: LLM LNS Swap error message #8708

Merged
merged 5 commits into from
Dec 20, 2024

Conversation

andreicovaciu
Copy link
Contributor

@andreicovaciu andreicovaciu commented Dec 17, 2024

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

πŸ“ Description

LIVE-14913: Adds LLM LNS Error message when incompatible to swap.

image
image

❓ Context

  • JIRA or GitHub link:

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@andreicovaciu andreicovaciu requested review from a team as code owners December 17, 2024 08:30
Copy link

vercel bot commented Dec 17, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Dec 19, 2024 4:22pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Dec 19, 2024 4:22pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Dec 19, 2024 4:22pm
web-tools ⬜️ Ignored (Inspect) Visit Preview Dec 19, 2024 4:22pm

@live-github-bot live-github-bot bot added mobile Has changes in LLM translations Translation files have been touched labels Dec 17, 2024
@andreicovaciu andreicovaciu changed the title feat: LLM LNS Swap error message feat: WIP LLM LNS Swap error message Dec 17, 2024
@andreicovaciu andreicovaciu requested a review from a team as a code owner December 18, 2024 05:46
@andreicovaciu andreicovaciu changed the title feat: WIP LLM LNS Swap error message feat: LLM LNS Swap error message Dec 18, 2024
@live-github-bot live-github-bot bot added the desktop Has changes in LLD label Dec 19, 2024
@andreicovaciu andreicovaciu merged commit fd44b1c into develop Dec 20, 2024
46 of 48 checks passed
@andreicovaciu andreicovaciu deleted the feat/LIVE-14913-add-llm-lns-swap-error branch December 20, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop Has changes in LLD mobile Has changes in LLM translations Translation files have been touched
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants