Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(LIVE-14956): Set a default 0 value for swap transactions #8710

Merged
merged 3 commits into from
Dec 20, 2024
Merged

fix(LIVE-14956): Set a default 0 value for swap transactions #8710

merged 3 commits into from
Dec 20, 2024

Conversation

Couto
Copy link
Contributor

@Couto Couto commented Dec 17, 2024

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

📝 Description

Allow ledger-live to define an amount to swap. (Set to 0)

❓ Context

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@Couto Couto requested review from a team as code owners December 17, 2024 08:53
@vercel Vercel
Copy link

vercel bot commented Dec 17, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Dec 18, 2024 4:53am
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Dec 18, 2024 4:53am
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Dec 18, 2024 4:53am
web-tools ⬜️ Ignored (Inspect) Visit Preview Dec 18, 2024 4:53am

@live-github-bot live-github-bot bot added the desktop Has changes in LLD label Dec 17, 2024
@Couto Couto force-pushed the fix/LIVE-14956-you-send-amount-persist branch from b036e41 to 6e11c96 Compare December 18, 2024 04:53
@Couto Couto merged commit 02fd6c3 into develop Dec 20, 2024
41 checks passed
@Couto Couto deleted the fix/LIVE-14956-you-send-amount-persist branch December 20, 2024 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcayuelas-ledger mcayuelas-ledger mcayuelas-ledger approved these changes

@liviuciulinaru liviuciulinaru liviuciulinaru approved these changes

Assignees

@Couto Couto

Labels
desktop Has changes in LLD
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Couto @liviuciulinaru @mcayuelas-ledger