fix(llm): 🎥 render camera feed right after granting access #8712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 4 Skipped Deployments
|
thesan
force-pushed
the
fix/llm-ios-camera-access
branch
from
c938063 to
f32842c
Compare
thesan
commented
Dec 18, 2024
| }} | ||
| onBarcodeScanned={onBarCodeScanned} | ||
| /> | ||
| <CameraPermissionContext.Consumer> |
There was a problem hiding this comment.
I tried to define a component to avoid using CameraPermissionContext.Consumer:
function WaitForPermissionCameraView(props: CameraProps) {
const { permissionGranted } = useContext(CameraPermissionContext);
return <CameraView active={permissionGranted ?? false} {...props} />;
}But this implementation didn't solves the problem on iOS (even when adding a key changing based on the permission).
themooneer
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ Checklist
npx changesetwas attached.📝 Description
Before
camera-permission-bug-with-blur.mov
After
camera-permission-fix-with-blur.mov
❓ Context
🧐 Checklist for the PR Reviewers