Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CN-761: added stakekit entrypoints for LLM and LLD #8722

Merged
merged 7 commits into from
Dec 19, 2024

Conversation

adammino-ledger
Copy link
Contributor

@adammino-ledger adammino-ledger commented Dec 17, 2024

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • Stake for BNB will open directly the Stakekit live app

πŸ“ Description

This PR adds staking capabilities for BNB, once a entrypoint has been pressed the Stakekit live app will open directly.

❓ Context

  • JIRA or GitHub link:

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@adammino-ledger adammino-ledger requested a review from a team as a code owner December 17, 2024 14:33
Copy link

vercel bot commented Dec 17, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
native-ui-storybook βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Dec 19, 2024 4:49pm
web-tools βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Dec 19, 2024 4:49pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Dec 19, 2024 4:49pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Dec 19, 2024 4:49pm

@live-github-bot live-github-bot bot added desktop Has changes in LLD mobile Has changes in LLM labels Dec 17, 2024
Justkant
Justkant previously approved these changes Dec 18, 2024
Copy link
Contributor

@Justkant Justkant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adammino-ledger adammino-ledger merged commit a69bfc0 into develop Dec 19, 2024
47 of 48 checks passed
@adammino-ledger adammino-ledger deleted the feat/add-bnb-stakekit-entrypoints branch December 19, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop Has changes in LLD mobile Has changes in LLM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants