[DSDK-620] Fix LLD crash (race condition in transport registration)

[ofreyssinet-ledger]

✅ Checklist

• npx changeset was attached.
• Covered by automatic tests.
• Impact of the changes:
  • Device interactions should work fine with:
    • with Ledger Device Management Kit disabled
    • with Ledger Device Management Kit enabled (ldmkTransport feature flag)
    • Speculos

📝 Description

Sentry issue: https://ledger.sentry.io/issues/6147489966/?project=6488660&query=release:2.94.0

Two things:

• getFeature return type was any, which allowed an error to slip through: checking the value of null.enabled.
• this was happening only in some cases, because of a race condition between:
  • the initialization of Firebase
  • the registration of transport modules

The result is a crash that would have looked like this for a user:

The fix:

• typing getFeature to return Feature | null.
• all transport modules are registered at initialization, with a more dynamic logic to choose which transport to use whenever withDevice is called. This is not really a new logic, withDevice has been conceived to work like this.

❓ Context

• JIRA or GitHub link: DSDK-620

---

🧐 Checklist for the PR Reviewers

• The code aligns with the requirements described in the linked JIRA or GitHub issue.
• The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
• There are no undocumented trade-offs, technical debt, or maintainability issues.
• The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
• Any new dependencies have been justified and documented.
• Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

4 Skipped Deployments

Name	Status	Preview	Comments	Updated (UTC)
ledger-live-github-bot	⬜️ Ignored (Inspect)	Visit Preview		Dec 18, 2024 10:50am
native-ui-storybook	⬜️ Ignored (Inspect)	Visit Preview		Dec 18, 2024 10:50am
react-ui-storybook	⬜️ Ignored (Inspect)	Visit Preview		Dec 18, 2024 10:50am
web-tools	⬜️ Ignored (Inspect)	Visit Preview		Dec 18, 2024 10:50am

[beths-ledger]

much needed type safety here