Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Detox] Update Detox and Allure reporter #8730

Merged
merged 5 commits into from
Dec 18, 2024
Merged

[Detox] Update Detox and Allure reporter #8730

merged 5 commits into from
Dec 18, 2024

Conversation

abdurrahman-ledger
Copy link
Contributor

@abdurrahman-ledger abdurrahman-ledger commented Dec 18, 2024 •
edited
Loading

✅ Checklist

  • npx changeset was attached. (no need)
  • Covered by automatic tests.
  • Impact of the changes:
    • LLM E2E tests

📝 Description

Updating :

Fixing

  • Prevent LLM Android sharding for PR checks
  • Store the runner name for allure timeline fix
Screenshot 2024-12-18 at 15 54 10

❓ Context

  • PR sharding fix run
  • Speculos run

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@vercel Vercel
Copy link

vercel bot commented Dec 18, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Dec 18, 2024 2:51pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Dec 18, 2024 2:51pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Dec 18, 2024 2:51pm
web-tools ⬜️ Ignored (Inspect) Visit Preview Dec 18, 2024 2:51pm

@live-github-bot live-github-bot bot added the mobile Has changes in LLM label Dec 18, 2024
@live-github-bot live-github-bot bot added the automation CI/CD stuff label Dec 18, 2024
@abdurrahman-ledger abdurrahman-ledger force-pushed the support/qaa-395_update_detox branch from bd5f059 to 8c914ce Compare December 18, 2024 12:46
@abdurrahman-ledger abdurrahman-ledger force-pushed the support/qaa-395_update_detox branch from 8c914ce to 85b551d Compare December 18, 2024 12:50
@abdurrahman-ledger abdurrahman-ledger marked this pull request as ready for review December 18, 2024 13:38
@abdurrahman-ledger abdurrahman-ledger requested a review from a team December 18, 2024 13:39
@abdurrahman-ledger abdurrahman-ledger requested a review from a team as a code owner December 18, 2024 14:48
@abdurrahman-ledger abdurrahman-ledger merged commit 202a351 into develop Dec 18, 2024
59 of 61 checks passed
@abdurrahman-ledger abdurrahman-ledger deleted the support/qaa-395_update_detox branch December 18, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ypolishchuk-ledger ypolishchuk-ledger ypolishchuk-ledger approved these changes

@cgrellard-ledger cgrellard-ledger cgrellard-ledger approved these changes

Assignees

@abdurrahman-ledger abdurrahman-ledger

Labels
automation CI/CD stuff mobile Has changes in LLM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@abdurrahman-ledger @cgrellard-ledger @ypolishchuk-ledger