Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: show default validators #8736

Merged
merged 1 commit into from
Dec 19, 2024
Merged

Conversation

qperrot
Copy link
Contributor

@qperrot qperrot commented Dec 19, 2024

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • on showless we do show the selected validators (or default one if no selected)
    • on showall we do show the current selected validators first and the default one right after

📝 Description

Show the selected validators on show less, the default one always on top or second (if we do have a current one already selected)

Screen.Recording.2024-12-19.at.08.05.39.mov

❓ Context


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

Copy link

vercel bot commented Dec 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web-tools ❌ Failed (Inspect) Dec 19, 2024 1:03pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Dec 19, 2024 1:03pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Dec 19, 2024 1:03pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Dec 19, 2024 1:03pm

@live-github-bot live-github-bot bot added the desktop Has changes in LLD label Dec 19, 2024
@qperrot qperrot force-pushed the bugfix/cardano-default-validators branch from 21534fd to c22fe20 Compare December 19, 2024 07:29
@qperrot qperrot marked this pull request as ready for review December 19, 2024 10:00
@qperrot qperrot requested a review from a team as a code owner December 19, 2024 10:00
@qperrot qperrot merged commit 340a171 into develop Dec 19, 2024
52 of 53 checks passed
@qperrot qperrot deleted the bugfix/cardano-default-validators branch December 19, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop Has changes in LLD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants