Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[QAA-383] Swap tests - Entry points #8737

Merged
merged 2 commits into from
Dec 19, 2024
Merged

[QAA-383] Swap tests - Entry points #8737

merged 2 commits into from
Dec 19, 2024

Conversation

VicAlbr
Copy link
Contributor

@VicAlbr VicAlbr commented Dec 19, 2024

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

📝 Description

Adding new Swap scenarios:

  • Entry Point - Portfolio page
  • Entry Point - Asset Allocation
  • Entry Point - Market page - 1
  • Entry Point - Market page - 2
  • Entry Point - Account page
  • Entry Point - left menu

❓ Context

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@vercel Vercel
Copy link

vercel bot commented Dec 19, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Dec 19, 2024 2:27pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Dec 19, 2024 2:27pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Dec 19, 2024 2:27pm
web-tools ⬜️ Ignored (Inspect) Visit Preview Dec 19, 2024 2:27pm

@live-github-bot live-github-bot bot added the desktop Has changes in LLD label Dec 19, 2024
@VicAlbr VicAlbr marked this pull request as ready for review December 19, 2024 10:04
@VicAlbr VicAlbr requested review from a team as code owners December 19, 2024 10:04
ypolishchuk-ledger
ypolishchuk-ledger reviewed Dec 19, 2024
View reviewed changes
apps/ledger-live-desktop/tests/page/asset.page.ts Show resolved Hide resolved
apps/ledger-live-desktop/tests/page/swap.page.ts Outdated Show resolved Hide resolved
apps/ledger-live-desktop/tests/page/swap.page.ts Outdated Show resolved Hide resolved
apps/ledger-live-desktop/tests/page/swap.page.ts Show resolved Hide resolved
apps/ledger-live-desktop/tests/specs/speculos/swap.spec.ts

test.describe("Swap flow from different entry point", () => {
test.beforeAll(async () => {
process.env.SWAP_DISABLE_APPS_INSTALL = "true";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure whether we need all these envs if in your tests you don't do actual swap flow

Copy link
Contributor Author

@VicAlbr VicAlbr Dec 19, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think SWAP_DISABLE_APPS_INSTALL and SWAP_API_BASE are mandatory to target the correct version of the live app.
Do you confirm @bharamboure-ledger ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep, I think you can remove the broadcasting var

Copy link
Contributor

@bharamboure-ledger bharamboure-ledger Dec 19, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SWAP_DISABLE_APPS_INSTALL is actually to prevent apps version check and rely on those we considered app candidates (prod versions) for speculos
SWAP_API_BASE is to target correct firebase env with proper flags
edit: to me they're both required

apps/ledger-live-desktop/tests/specs/speculos/swap.spec.ts Show resolved Hide resolved
apps/ledger-live-desktop/tests/specs/speculos/swap.spec.ts Outdated Show resolved Hide resolved
@VicAlbr VicAlbr force-pushed the support/qaa-383 branch 3 times, most recently from 75fdbd5 to 9bef36a Compare December 19, 2024 14:14
@VicAlbr VicAlbr merged commit 70877ab into develop Dec 19, 2024
40 of 41 checks passed
@VicAlbr VicAlbr deleted the support/qaa-383 branch December 19, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bharamboure-ledger bharamboure-ledger bharamboure-ledger left review comments

@ypolishchuk-ledger ypolishchuk-ledger ypolishchuk-ledger approved these changes

Assignees

@VicAlbr VicAlbr

Labels
desktop Has changes in LLD
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@VicAlbr @ypolishchuk-ledger @bharamboure-ledger