bugfix: Token listed multiple times without account details in Receive flow #8743
+14
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 4 Skipped Deployments
|
LucasWerey
reviewed
Dec 20, 2024
| @@ -39,9 +41,11 @@ const AccountCard = ({ | |||
| ...props | |||
There was a problem hiding this comment.
You can remove parentAccount from the props since you don't use it anymore
There was a problem hiding this comment.
update it here too apps/ledger-live-mobile/src/newArch/features/Web3Hub/screens/Web3HubApp/components/Web3Player/SelectAccountModal/AccountsList/index.tsx and apps/ledger-live-mobile/src/screens/RequestAccount/02-SelectAccount.tsx
There was a problem hiding this comment.
It's used direclty inside component :) So no need to update other file
btw i'll update logic because maybe in some cases parentAccount will not be undefined
mcayuelas-ledger
force-pushed
the
bugfix/LIVE-15526
branch
from
ab10361 to
a599339
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ Checklist
npx changesetwas attached.📝 Description
Token listed multiple times without account details in Receive flow
Screen_Recording_20241220_102442_LL.DEV.mp4
Screen_Recording_20241220_102516_LL.DEV.mp4
❓ Context
🧐 Checklist for the PR Reviewers