Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: delegation showless #8744

Merged
merged 1 commit into from
Dec 20, 2024
Merged

Conversation

qperrot
Copy link
Contributor

@qperrot qperrot commented Dec 20, 2024

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

πŸ“ Description

Delegate SOL
Select a new provider (not a ledger one)
Click on show less
Provider is be displayed on the modal

Screen.Recording.2024-12-20.at.13.39.19.mov

❓ Context


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

Copy link

vercel bot commented Dec 20, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Dec 20, 2024 0:42am
native-ui-storybook ⬜️ Ignored (Inspect) Dec 20, 2024 0:42am
react-ui-storybook ⬜️ Ignored (Inspect) Dec 20, 2024 0:42am
web-tools ⬜️ Ignored (Inspect) Dec 20, 2024 0:42am

@qperrot qperrot marked this pull request as ready for review December 20, 2024 12:42
@qperrot qperrot requested a review from a team as a code owner December 20, 2024 12:42
@live-github-bot live-github-bot bot added the desktop Has changes in LLD label Dec 20, 2024
@qperrot qperrot merged commit a531200 into develop Dec 20, 2024
42 of 46 checks passed
@qperrot qperrot deleted the bugfix/validators-solana-showless branch December 20, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop Has changes in LLD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants