Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed additional settings from Ledger Live Desktop. #8747

Open
wants to merge 1 commit into
base: feat/integrate-aptos
Choose a base branch
from

Conversation

joaoccmartins
Copy link

@joaoccmartins joaoccmartins commented Dec 20, 2024

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

📝 Description

Replace this text by a clear and concise description of what this pull request is about and why it is needed. Be sure to explain the problem you're addressing and the solution you're proposing.
For libraries, you can add a code sample of how to use it.
For bug fixes, you can explain the previous behaviour and how it was fixed.
In case of visual features, please attach screenshots or video recordings to demonstrate the changes.

❓ Context


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

Copy link

vercel bot commented Dec 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Dec 20, 2024 4:28pm
native-ui-storybook ⬜️ Ignored (Inspect) Dec 20, 2024 4:28pm
react-ui-storybook ⬜️ Ignored (Inspect) Dec 20, 2024 4:28pm
web-tools ⬜️ Ignored (Inspect) Dec 20, 2024 4:28pm

@live-github-bot live-github-bot bot added desktop Has changes in LLD translations Translation files have been touched labels Dec 20, 2024
@live-github-bot
Copy link
Contributor

Desktop Bundle Checks

Comparing 6b8503c against 370612f.

⚠️ main bundle size significantly increased: 1.8mb -> 2mb. Please check if this is expected.
⚠️ renderer bundle size significantly increased: 36.7mb -> 38.1mb. Please check if this is expected.
⚠️ @opentelemetry/semantic-conventions library is now duplicated in main (regression)
⚠️ @opentelemetry/core library is now duplicated in main (regression)
⚠️ ms library is now duplicated in main (regression)
⚠️ debug library is now duplicated in main (regression)
⚠️ ajv library is now duplicated in main (regression)
⚠️ @celo/base/lib/address library is now duplicated in renderer (regression)
⚠️ @celo/base/lib/signatureUtils library is now duplicated in renderer (regression)
⚠️ @celo/utils/lib/address library is now duplicated in renderer (regression)
⚠️ @celo/utils/lib/solidity library is now duplicated in renderer (regression)
⚠️ @celo/utils/lib/signatureUtils library is now duplicated in renderer (regression)

@joaoccmartins joaoccmartins changed the title WIP: Removed additional settings from Ledger Live Desktop. Removed additional settings from Ledger Live Desktop. Dec 20, 2024
@joaoccmartins joaoccmartins marked this pull request as ready for review December 20, 2024 17:07
@joaoccmartins joaoccmartins requested a review from a team as a code owner December 20, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop Has changes in LLD translations Translation files have been touched
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant