Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: Click on MarketWidget under FF #8754

Merged
merged 1 commit into from
Dec 23, 2024

Conversation

mcayuelas-ledger
Copy link
Contributor

@mcayuelas-ledger mcayuelas-ledger commented Dec 23, 2024

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

πŸ“ Description

Click on MarketWidget should be under FF

Screen.Recording.2024-12-23.at.14.57.43.mov

❓ Context


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@mcayuelas-ledger mcayuelas-ledger requested a review from a team as a code owner December 23, 2024 13:53
Copy link

vercel bot commented Dec 23, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Dec 23, 2024 1:53pm
native-ui-storybook ⬜️ Ignored (Inspect) Dec 23, 2024 1:53pm
react-ui-storybook ⬜️ Ignored (Inspect) Dec 23, 2024 1:53pm
web-tools ⬜️ Ignored (Inspect) Dec 23, 2024 1:53pm

@live-github-bot live-github-bot bot added the desktop Has changes in LLD label Dec 23, 2024
@mcayuelas-ledger mcayuelas-ledger merged commit 4fad912 into develop Dec 23, 2024
42 of 46 checks passed
@mcayuelas-ledger mcayuelas-ledger deleted the bugfix/market-widget branch December 23, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop Has changes in LLD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants