Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: earn on llm #8756

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

fix: earn on llm #8756

wants to merge 1 commit into from

Conversation

qperrot
Copy link
Contributor

@qperrot qperrot commented Dec 23, 2024

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • click on earn button must work excepte for empty accounts.

πŸ“ Description

  • Go to Earn on LLM
  • If you have some SOL you should be able to go on stake page when clicking on earn.

Uploading Screen Recording 2024-12-23 at 16.22.27.mov…

❓ Context


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

Copy link

vercel bot commented Dec 23, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
web-tools βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Dec 23, 2024 3:32pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Dec 23, 2024 3:32pm
native-ui-storybook ⬜️ Ignored (Inspect) Dec 23, 2024 3:32pm
react-ui-storybook ⬜️ Ignored (Inspect) Dec 23, 2024 3:32pm

@@ -69,6 +69,13 @@ export const isAccountEmpty = (a: AccountLike): boolean => {
(a as any).balance.isZero()
);
}
if (a.type === "Account" && a.currency.family === "solana") {
return (
(a as any).solanaResources &&
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why check for solana resources here?

if (a.type === "Account" && a.currency.family === "solana") {
return (
(a as any).solanaResources &&
(a as any).balance.isZero() &&
Copy link
Contributor

@Wozacosta Wozacosta Dec 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wouldn't we want delegation to be disabled if balance isZero OR spendableBalance isZero ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mobile Has changes in LLM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants