Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: earn on llm #8756

Merged
merged 3 commits into from
Jan 13, 2025
Merged

fix: earn on llm #8756

merged 3 commits into from
Jan 13, 2025

Conversation

qperrot
Copy link
Contributor

@qperrot qperrot commented Dec 23, 2024 •
edited
Loading

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • click on earn button must work excepte for empty accounts.

📝 Description

  • Go to Earn on LLM
  • If you have some SOL you should be able to go on stake page when clicking on earn.

Uploading Screen Recording 2024-12-23 at 16.22.27.mov…

❓ Context

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@vercel Vercel
Copy link

vercel bot commented Dec 23, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web-tools ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 13, 2025 1:59pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Jan 13, 2025 1:59pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Jan 13, 2025 1:59pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Jan 13, 2025 1:59pm

@live-github-bot live-github-bot bot added the mobile Has changes in LLM label Dec 23, 2024
@qperrot qperrot marked this pull request as ready for review December 27, 2024 08:55
@qperrot qperrot requested a review from a team as a code owner December 27, 2024 08:55
@qperrot qperrot requested a review from Wozacosta December 27, 2024 08:55
hedi-edelbloute
hedi-edelbloute reviewed Dec 31, 2024
View reviewed changes
Copy link
Member

@hedi-edelbloute hedi-edelbloute left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unit tests please !

Canestin
Canestin previously approved these changes Jan 9, 2025
View reviewed changes
@qperrot qperrot merged commit 80a46be into develop Jan 13, 2025
53 of 55 checks passed
@qperrot qperrot deleted the bugfix/solana-delegation-llm branch January 13, 2025 14:39
qperrot added a commit that referenced this pull request Jan 28, 2025
@qperrot
Revert "Merge pull request #8756 from LedgerHQ/bugfix/solana-delegati…
cc82936 
…on-llm"

This reverts commit 80a46be, reversing
changes made to eb948eb.
qperrot added a commit that referenced this pull request Jan 28, 2025
@qperrot
Revert "Merge pull request #8756 from LedgerHQ/bugfix/solana-delegati…
7e8983c 
…on-llm"

This reverts commit 80a46be, reversing
changes made to eb948eb.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hedi-edelbloute hedi-edelbloute hedi-edelbloute left review comments

@Canestin Canestin Canestin approved these changes

@Wozacosta Wozacosta Wozacosta approved these changes

Assignees

@qperrot qperrot

Labels
mobile Has changes in LLM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@qperrot @Wozacosta @hedi-edelbloute @Canestin