Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QAA][Playwright][Speculos] Fix timeout issues #8758

Merged
merged 3 commits into from
Dec 24, 2024

Conversation

abdurrahman-ledger
Copy link
Contributor

@abdurrahman-ledger abdurrahman-ledger commented Dec 24, 2024

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

📝 Description

The retry mechanism for Speculos was broken making Speculos tests timeout when address already used in runners.

❓ Context

Speculos run


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

Copy link

vercel bot commented Dec 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web-tools ❌ Failed (Inspect) Dec 24, 2024 9:08am
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Dec 24, 2024 9:08am
native-ui-storybook ⬜️ Ignored (Inspect) Dec 24, 2024 9:08am
react-ui-storybook ⬜️ Ignored (Inspect) Dec 24, 2024 9:08am

@live-github-bot live-github-bot bot added desktop Has changes in LLD common Has changes in live-common labels Dec 24, 2024
@abdurrahman-ledger abdurrahman-ledger marked this pull request as ready for review December 24, 2024 12:56
@abdurrahman-ledger abdurrahman-ledger requested review from a team as code owners December 24, 2024 12:56
@ypolishchuk-ledger ypolishchuk-ledger merged commit 3f98074 into develop Dec 24, 2024
69 of 78 checks passed
@ypolishchuk-ledger ypolishchuk-ledger deleted the support/fix-speculos-issue branch December 24, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
common Has changes in live-common desktop Has changes in LLD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants