Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add error page for LLM #8762

Merged
merged 1 commit into from
Jan 3, 2025
Merged

feat: add error page for LLM #8762

merged 1 commit into from
Jan 3, 2025

Conversation

liviuciulinaru
Copy link
Contributor

@liviuciulinaru liviuciulinaru commented Dec 24, 2024 •
edited
Loading

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

📝 Description

  • navigate to error screen if live app is at /unknown-error
image

❓ Context

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@liviuciulinaru liviuciulinaru requested a review from a team as a code owner December 24, 2024 15:10
@vercel Vercel
Copy link

vercel bot commented Dec 24, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Jan 3, 2025 7:58am
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Jan 3, 2025 7:58am
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Jan 3, 2025 7:58am
web-tools ⬜️ Ignored (Inspect) Visit Preview Jan 3, 2025 7:58am

@live-github-bot live-github-bot bot added the mobile Has changes in LLM label Dec 24, 2024
lpaquet-ledger
lpaquet-ledger previously approved these changes Dec 24, 2024
View reviewed changes
@liviuciulinaru liviuciulinaru marked this pull request as draft January 2, 2025 12:33
@live-github-bot live-github-bot bot added the translations Translation files have been touched label Jan 3, 2025
@liviuciulinaru
feat: add error page
74ce7a7 
fix: use i18n

chore: logs

chore: changeset
@liviuciulinaru liviuciulinaru force-pushed the fix/live-10697/llm-error-page branch from a1ccb1f to 74ce7a7 Compare January 3, 2025 07:58
@liviuciulinaru liviuciulinaru marked this pull request as ready for review January 3, 2025 08:11
@liviuciulinaru liviuciulinaru merged commit 1d47a95 into develop Jan 3, 2025
42 of 45 checks passed
@liviuciulinaru liviuciulinaru deleted the fix/live-10697/llm-error-page branch January 3, 2025 11:12
ThatOneCalculator pushed a commit to ThatOneCalculator/ledger-live that referenced this pull request Jan 6, 2025
@liviuciulinaru @ThatOneCalculator
feat: add error page for LLM (LedgerHQ#8762)
8d4d229 
feat: add error page

fix: use i18n

chore: logs

chore: changeset
This was referenced Jan 7, 2025
Open
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpaquet-ledger lpaquet-ledger lpaquet-ledger approved these changes

Assignees

@liviuciulinaru liviuciulinaru

Labels
mobile Has changes in LLM translations Translation files have been touched
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@liviuciulinaru @lpaquet-ledger