chore: Add market widget integration test ✅ #8777
Open
+909
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 4 Skipped Deployments
|
Wiz Scan Summary
To detect these findings earlier in the dev lifecycle, try using Wiz Code VS Code Extension. |
mcayuelas-ledger
force-pushed
the
chore/market-widget-integration-test
branch
3 times, most recently
from
f7c14f5 to
12c75d2
Compare
themooneer
reviewed
Jan 3, 2025
| @@ -57,6 +57,7 @@ function WidgetRow({ data, index, range, enableNewFeature }: PropsBodyElem) { | |||
| py="6px" | |||
| onClick={enableNewFeature ? onCurrencyClick : undefined} | |||
| featureFlagEnabled={enableNewFeature} | |||
| data-testid={"market-performance-widget-row-" + index} | |||
There was a problem hiding this comment.
"market-performance-widget-row-" + index ->
`market-performance-widget-row-${index}`
themooneer
reviewed
Jan 3, 2025
| @@ -1,7 +1,7 @@ | |||
| import { MarketItemPerformer } from "@ledgerhq/live-common/market/utils/types"; | |||
| import { PortfolioRange } from "@ledgerhq/types-live"; | |||
|
|
|||
| import { CurrencyCheck, Order } from "~/renderer/screens/dashboard/MarketPerformanceWidget/types"; | |||
| import { CurrencyCheck, Order } from "~/newArch/features/MarketPerformanceWidget/types"; | |||
There was a problem hiding this comment.
LLD/features/arketPerformanceWidget/types
themooneer
reviewed
Jan 3, 2025
| @@ -0,0 +1,22 @@ | |||
| /* eslint-disable @typescript-eslint/no-unused-vars */ | |||
There was a problem hiding this comment.
is it possible to get rid of this ? if not can you add a comment above to justify why ? thanks
mcayuelas-ledger
force-pushed
the
chore/market-widget-integration-test
branch
from
12c75d2 to
8df3136
Compare
themooneer
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ Checklist
npx changesetwas attached.📝 Description
Architecture Changes:
Enhancements:
❓ Context
🧐 Checklist for the PR Reviewers