Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(aptos): improve aptos unit tests #8781

Merged
merged 7 commits into from
Jan 6, 2025

Conversation

jccguimaraes
Copy link
Member

@jccguimaraes jccguimaraes commented Dec 31, 2024

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

πŸ“ Description

Adds improvements to aptos unit tests

Coverage for the current test

  • 100% Statements 57/57
  • 100% Branches 15/15
  • 100% Functions 5/5
  • 100% Lines 55/55

❓ Context

  • JIRA or GitHub link:

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

Copy link

vercel bot commented Dec 31, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
web-tools βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Jan 3, 2025 5:59pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Jan 3, 2025 5:59pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Jan 3, 2025 5:59pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Jan 3, 2025 5:59pm

@live-github-bot
Copy link
Contributor

live-github-bot bot commented Dec 31, 2024

Desktop Bundle Checks

Comparing b290342 against a070f4e.

⚠️ renderer bundle size significantly increased: 36.7mb -> 37.8mb. Please check if this is expected.

Mobile Bundle Checks

Comparing b290342 against a070f4e.

⚠️ main.ios.jsbundle bundle size significantly increased: 60.3mb -> 61.7mb. Please check if this is expected.
⚠️ main.android.jsbundle bundle size significantly increased: 60.3mb -> 61.7mb. Please check if this is expected.

@jccguimaraes jccguimaraes changed the title feat(aptos): improve bot specs file feat(aptos): improve aptos unit tests Jan 3, 2025
@jccguimaraes jccguimaraes merged commit b901ba9 into feat/integrate-aptos Jan 6, 2025
52 of 54 checks passed
@jccguimaraes jccguimaraes deleted the test/LIVE-15128_unit_tests branch January 6, 2025 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
common Has changes in live-common
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants