Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(aptos): improve unit tests #8792

Merged
merged 3 commits into from
Jan 3, 2025

Conversation

jccguimaraes
Copy link
Member

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

📝 Description

Adds improvements to aptos unit tests

Coverage for the current test

  • 100% Statements 57/57
  • 100% Branches 15/15
  • 100% Functions 5/5
  • 100% Lines 55/55

❓ Context

  • JIRA or GitHub link:

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@jccguimaraes jccguimaraes requested a review from a team as a code owner January 2, 2025 17:40
Copy link

vercel bot commented Jan 2, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web-tools ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 3, 2025 10:56am
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Jan 3, 2025 10:56am
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Jan 3, 2025 10:56am
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Jan 3, 2025 10:56am

@live-github-bot
Copy link
Contributor

live-github-bot bot commented Jan 2, 2025

Desktop Bundle Checks

Comparing 5f447f2 against 8d2cf10.

⚠️ renderer bundle size significantly increased: 36.7mb -> 37.8mb. Please check if this is expected.

Mobile Bundle Checks

Comparing 5f447f2 against 8d2cf10.

⚠️ main.ios.jsbundle bundle size significantly increased: 60.3mb -> 61.7mb. Please check if this is expected.
⚠️ main.android.jsbundle bundle size significantly increased: 60.3mb -> 61.7mb. Please check if this is expected.

@jccguimaraes jccguimaraes merged commit 37d0efd into feat/integrate-aptos Jan 3, 2025
54 checks passed
@jccguimaraes jccguimaraes deleted the test/LIVE-15130_unit_tests branch January 3, 2025 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
common Has changes in live-common
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants