Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

live-wallet store account names and starred accounts in storage #8835

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

KVNLS
Copy link
Member

@KVNLS KVNLS commented Jan 7, 2025

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

πŸ“ Description

When we reworked the account model last year, we extracted accountNames and starredAccounts from the accounts model to the wallet model. But we forgot to store those values in Storage (app.json).
Plus as we use a Map and a Set we need to convert them into an Array before storing them.

Before

Account.Name.Change.mov

After

Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2025-01-07.at.15.54.40.mp4

❓ Context


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@KVNLS KVNLS self-assigned this Jan 7, 2025
Copy link

vercel bot commented Jan 7, 2025

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
web-tools βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Jan 7, 2025 2:58pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Jan 7, 2025 2:58pm
native-ui-storybook ⬜️ Ignored (Inspect) Jan 7, 2025 2:58pm
react-ui-storybook ⬜️ Ignored (Inspect) Jan 7, 2025 2:58pm

@KVNLS KVNLS marked this pull request as ready for review January 7, 2025 16:48
@KVNLS KVNLS requested a review from a team as a code owner January 7, 2025 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant