Feat/live 15551 aptos refactor cache for get estimated gas #8848

may01 · 2025-01-08T23:41:52Z

✅ Checklist

npx changeset was attached.
Covered by automatic tests.
Impact of the changes:
- aptos fee estimation

📝 Description

The cache for transaction fees was broken, and after the removal of the advanced transaction settings, there is unnecessary logic and structures remaining in the code.

Issues that were resolved:

The cached value was stored to the wrong key in some cases.
Removed redundant call to estimate the gas price. Now, the price is taken from the simulation.
Optional parameters corresponding to advanced user input have been removed.
Previously, the simulation used default parameters for the first call and estimated parameters for subsequent calls, which created potential side effects. Now, all simulations use default parameters (gasPrice, gasAmount).
If the simulation fails, we now set default values instead of using the latest estimated value.
The transaction status check has been updated to use only relevant parameters.

❓ Context

JIRA or GitHub link:

🧐 Checklist for the PR Reviewers

The code aligns with the requirements described in the linked JIRA or GitHub issue.
The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
There are no undocumented trade-offs, technical debt, or maintainability issues.
The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
Any new dependencies have been justified and documented.
Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

vercel · 2025-01-08T23:41:56Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
web-tools	❌ Failed (Inspect)			Jan 10, 2025 4:21pm

3 Skipped Deployments

Name	Status	Preview	Updated (UTC)
ledger-live-github-bot	⬜️ Ignored (Inspect)	Visit Preview	Jan 10, 2025 4:21pm
native-ui-storybook	⬜️ Ignored (Inspect)	Visit Preview	Jan 10, 2025 4:21pm
react-ui-storybook	⬜️ Ignored (Inspect)	Visit Preview	Jan 10, 2025 4:21pm

libs/ledger-live-common/src/families/aptos/api/index.ts

libs/ledger-live-common/src/families/aptos/buildTransaction.ts

libs/ledger-live-common/src/families/aptos/getFeesForTransaction.ts

libs/ledger-live-common/src/families/aptos/logic.ts

libs/ledger-live-common/src/families/aptos/getFeesForTransaction.ts

ledger-wiz-cspm-secret-detection · 2025-01-09T14:28:10Z

Wiz Scan Summary

Scanner	Findings
Sensitive Data
Secrets
IaC Misconfigurations

Total

View scan details in Wiz

To detect these findings earlier in the dev lifecycle, try using Wiz Code VS Code Extension.

ledger-wiz-cspm-secret-detection · 2025-01-09T14:28:10Z

Wiz Scan Summary

Scanner	Findings
Sensitive Data	2
Secrets
IaC Misconfigurations

Total	2

View scan details in Wiz

To detect these findings earlier in the dev lifecycle, try using Wiz Code VS Code Extension.

libs/ledger-live-common/src/families/aptos/prepareTransaction.ts

jccguimaraes · 2025-01-10T09:56:44Z

libs/ledger-live-common/src/families/aptos/getFeesForTransaction.ts

-
-  if (!CACHE.has(key)) {
-    CACHE.set(key, await getFee(account, transaction, aptosClient));
+  if (!CACHE.amount.eq(transaction.amount)) {


@hedi-edelbloute does makeLRUCache removes the need for the CACHE?

semeano · 2025-01-10T12:48:36Z

libs/ledger-live-common/src/families/aptos/bridge.integration.test.ts

@@ -64,10 +64,8 @@ const aptos: CurrenciesData<Transaction> = {
            family: "aptos",
            mode: "send",
            fees: "1100",
-            options: '{ "maxGasAmount": "11", "gasUnitPrice": "100" }',
-            estimate:
+            options:
              '{ "maxGasAmount": "11", "gasUnitPrice": "100", "sequenceNumber": "1", "expirationTimestampSecs": "1734535375" }',


wasn't sequenceNumber and expirationTimestampSecs removed?

this is a good point. If it was removed, how did it not failed? 🤔

semeano

Check my latest comments

semeano · 2025-01-10T17:29:58Z

apps/ledger-live-mobile/src/locales/en/common.json

    "SequenceNumberError": {
      "title": "Sequence number error",
      "description": "Please close the window and try again later"


Shouldn't this be removed also?

semeano · 2025-01-10T17:30:19Z

libs/ledger-live-common/src/families/aptos/api/index.test.ts

@@ -415,7 +411,6 @@ describe("Aptos API", () => {
        options: {
          maxGasAmount: Number(options.maxGasAmount),
          gasUnitPrice: Number(options.gasUnitPrice),
-          accountSequenceNumber: Number(options.sequenceNumber),
          expireTimestamp: 120,


Do we need this line? ---> expireTimestamp: 120,

semeano · 2025-01-10T17:31:15Z

libs/ledger-live-common/src/families/aptos/getFeesForTransaction.test.ts

-        expect(result).toEqual(expected);
-      });
-    });
-
    describe("with vm_status as INSUFFICIENT_BALANCE", () => {
      it("should return a fee estimation object", async () => {
        simulateTransaction = jest.fn(() => [
          {
            success: false,
            vm_status: ["INSUFFICIENT_BALANCE"],
            expiration_timestamp_secs: 5,


Do we keep this line?

may01 requested a review from a team as a code owner January 8, 2025 23:41

github-actions bot assigned may01 Jan 8, 2025

live-github-bot bot added the common Has changes in live-common label Jan 8, 2025

may01 mentioned this pull request Jan 8, 2025

Tests update to follow up cache update #8849

Merged

3 tasks

vercel bot had a problem deploying to Preview – react-ui-storybook January 9, 2025 00:02 Failure

vercel bot had a problem deploying to Preview – native-ui-storybook January 9, 2025 00:02 Failure

vercel bot had a problem deploying to Preview – ledger-live-github-bot January 9, 2025 00:02 Failure

vercel bot had a problem deploying to Preview – web-tools January 9, 2025 00:02 Failure

vercel bot had a problem deploying to Preview – react-ui-storybook January 9, 2025 00:04 Failure

vercel bot had a problem deploying to Preview – web-tools January 9, 2025 00:06 Failure

semeano previously approved these changes Jan 9, 2025

View reviewed changes

jccguimaraes requested changes Jan 9, 2025

View reviewed changes

jccguimaraes reviewed Jan 9, 2025

View reviewed changes

libs/ledger-live-common/src/families/aptos/getFeesForTransaction.ts Show resolved Hide resolved

may01 dismissed semeano’s stale review via a0f23a7 January 9, 2025 14:07

may01 requested review from jccguimaraes and semeano January 9, 2025 14:11

vercel bot deployed to Preview – web-tools January 9, 2025 14:18 View deployment

may01 requested review from a team as code owners January 9, 2025 14:27

jccguimaraes requested changes Jan 10, 2025

View reviewed changes

may01 requested a review from jccguimaraes January 10, 2025 10:58

may01 force-pushed the feat/LIVE-15551-aptos-refactor-cache-for-get-estimated-gas branch from c362c13 to aad4ecf Compare January 10, 2025 11:48

semeano reviewed Jan 10, 2025

View reviewed changes

may01 dismissed hedi-edelbloute’s stale review via d35af06 January 10, 2025 13:34

vercel bot deployed to Preview – web-tools January 10, 2025 13:38 View deployment

ypolishchuk-ledger approved these changes Jan 10, 2025

View reviewed changes

jccguimaraes approved these changes Jan 10, 2025

View reviewed changes

may01 added 18 commits January 10, 2025 16:17

Dirty draft of changes

974c75e

Comment transaction.options parameter

92a5237

WIP: functional changes

2ef0a6d

Main logic change with removed options and fixed fees cache

d9d4351

Fix branch diff

e63fb3f

fix branch diff

d546a35

Tests update to follow up cache update

c8f0272

update mock

3ac9b7f

rename TransactionEstimate to TransactionOptions

2b6c712

Fix Number <-> BigNumber consistency

409b36f

fix logic tests

899f1b2

rename transaction.estimate to options

8c5d439

code review update

02f10b4

Remove file with unused errors

8784a31

Add async description

d1a8ae9

Add changeset

da8e822

remove unused translations

a08cf86

Review update

d2fbe96

may01 force-pushed the feat/LIVE-15551-aptos-refactor-cache-for-get-estimated-gas branch from d35af06 to d2fbe96 Compare January 10, 2025 16:18

vercel bot had a problem deploying to Preview – web-tools January 10, 2025 16:21 Failure

semeano self-requested a review January 10, 2025 17:08

semeano reviewed Jan 10, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feat/live 15551 aptos refactor cache for get estimated gas #8848

Feat/live 15551 aptos refactor cache for get estimated gas #8848

may01 commented Jan 8, 2025 •

edited

Loading

vercel bot commented Jan 8, 2025 •

edited

Loading

ledger-wiz-cspm-secret-detection bot commented Jan 9, 2025 •

edited

Loading

ledger-wiz-cspm-secret-detection bot commented Jan 9, 2025

jccguimaraes Jan 10, 2025

semeano Jan 10, 2025

jccguimaraes Jan 10, 2025

semeano left a comment

semeano Jan 10, 2025

semeano Jan 10, 2025 •

edited

Loading

semeano Jan 10, 2025

Feat/live 15551 aptos refactor cache for get estimated gas #8848

Are you sure you want to change the base?

Feat/live 15551 aptos refactor cache for get estimated gas #8848

Conversation

may01 commented Jan 8, 2025 • edited Loading

✅ Checklist

📝 Description

Issues that were resolved:

❓ Context

🧐 Checklist for the PR Reviewers

vercel bot commented Jan 8, 2025 • edited Loading

ledger-wiz-cspm-secret-detection bot commented Jan 9, 2025 • edited Loading

Wiz Scan Summary

ledger-wiz-cspm-secret-detection bot commented Jan 9, 2025

Wiz Scan Summary

jccguimaraes Jan 10, 2025

Choose a reason for hiding this comment

semeano Jan 10, 2025

Choose a reason for hiding this comment

jccguimaraes Jan 10, 2025

Choose a reason for hiding this comment

semeano left a comment

Choose a reason for hiding this comment

semeano Jan 10, 2025

Choose a reason for hiding this comment

semeano Jan 10, 2025 • edited Loading

Choose a reason for hiding this comment

semeano Jan 10, 2025

Choose a reason for hiding this comment

may01 commented Jan 8, 2025 •

edited

Loading

vercel bot commented Jan 8, 2025 •

edited

Loading

ledger-wiz-cspm-secret-detection bot commented Jan 9, 2025 •

edited

Loading

semeano Jan 10, 2025 •

edited

Loading