Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[QAA] Adding E2E test - User send funds to an ENS #8906

Merged
merged 1 commit into from
Jan 17, 2025
Merged

[QAA] Adding E2E test - User send funds to an ENS #8906

merged 1 commit into from
Jan 17, 2025

Conversation

VicAlbr
Copy link
Contributor

@VicAlbr VicAlbr commented Jan 15, 2025 •
edited by jira bot
Loading

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

📝 Description

  • Adding E2E test: User can send funds to an ENS address
  • Updating ENS for NFT test

❓ Context

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@vercel Vercel
Copy link

vercel bot commented Jan 15, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web-tools ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 17, 2025 1:14pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Jan 17, 2025 1:14pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Jan 17, 2025 1:14pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Jan 17, 2025 1:14pm

@live-github-bot live-github-bot bot added desktop Has changes in LLD common Has changes in live-common labels Jan 15, 2025
@VicAlbr VicAlbr changed the title [QAA] Adding E2E tes [QAA] Adding E2E test - User send funds to an ENS Jan 15, 2025
@VicAlbr VicAlbr marked this pull request as ready for review January 16, 2025 09:01
@VicAlbr VicAlbr requested review from a team as code owners January 16, 2025 09:01
@ypolishchuk-ledger ypolishchuk-ledger merged commit 91bb3fa into develop Jan 17, 2025
59 of 61 checks passed
@ypolishchuk-ledger ypolishchuk-ledger deleted the support/qaa-430 branch January 17, 2025 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ypolishchuk-ledger ypolishchuk-ledger ypolishchuk-ledger approved these changes

@cgrellard-ledger cgrellard-ledger cgrellard-ledger approved these changes

@abdurrahman-ledger abdurrahman-ledger Awaiting requested review from abdurrahman-ledger

Assignees

@VicAlbr VicAlbr

Labels
common Has changes in live-common desktop Has changes in LLD
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@VicAlbr @cgrellard-ledger @ypolishchuk-ledger @abdurrahman-ledger