Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚨 Release merge conflicts #8922

Merged
merged 95 commits into from
Jan 16, 2025
Merged

🚨 Release merge conflicts #8922

merged 95 commits into from
Jan 16, 2025

Conversation

live-github-bot[bot]
Copy link
Contributor

The release had some merge conflicts 🚨

This pull request was created in order to resolve the merge conflicts between the release and develop branches.

git checkout develop && git pull

git checkout support/release-merge-conflicts

git merge develop

Checklist

To be ready to be merged, we must comply with all theses checks:

  • all CI checks have passed
  • reviews of the code owners impacted by the conflict

⚠️ Warning ⚠️

Warning
Only merge the PR with the option Create a merge commit

live-github-bot bot and others added 30 commits November 15, 2024 16:39
[fix/LIVE-15117]: add custom ptx handlers to handlers memo
* fix: add ledger validator on mantra

* update snapshot
…wn (#8526)

* feat(llm): log category cards impression when 50% of the card is visible

* feat(llm): do not run in view checks when no items is being watched

* feat(llm): log portfolio content cards impression on 50% visibility

* chore: update change log

* feat(llm): log dynamic content card impression when 50% is shown

* feat(llm): log notification impression when 50% is shown

* chore(llm): rename IsInViewContext to InViewContext

* chore(llm): add InViewContextProvider to the AppProviders

* fix(llm): undefined order in null

* feat(lld): log category impression when 50% is shown

* chore(llm): use LLM alias in imports

* feat(llm): trigger segment event on card impression

* fix(llm): rewatch card when `LogContentCardWrapper.id` change

* fix(llm): use mobileCardsSelector to find the card to log the impression

* fix(llm): race condition between interval and inViewStatus

* chore(llm): check "exhaustive-deps" on `useInViewContext`

* chore(llm): remove unnecessary key
fix: Move ICP memo tag field on recepient step when FF lldMemoTag is ON
…8601)

* revert useNFTCollections

* improvement LLD

* Improve LLM
Release - fix(lld): use a debounce on memotag field
fix(llm): fix long Memo Tag issue in Stacks

chore: update change log

chore: update unimported

fix(llm): use `truncateUtf8` instead of `Array.slice`

chore(llm): use `maxLength` instead of `Array.slice` on Algorand

fix(llm): validate the memo bytes length instead of the js string length
fix(llm): debounce memo tag changes
* fix(llm): fix long memo issue on Cardano

* chore: update change log
@live-github-bot live-github-bot bot requested a review from a team as a code owner January 16, 2025 11:13
Copy link

vercel bot commented Jan 16, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web-tools ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 16, 2025 2:59pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Jan 16, 2025 2:59pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Jan 16, 2025 2:59pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Jan 16, 2025 2:59pm

@live-github-bot live-github-bot bot added desktop Has changes in LLD mobile Has changes in LLM common Has changes in live-common ui Has changes in the design system library ledgerjs Has changes in the ledgerjs open source libs translations Translation files have been touched screenshots Screenshots have been updated cli labels Jan 16, 2025
@ledger-wiz-cspm-secret-detection
Copy link

ledger-wiz-cspm-secret-detection bot commented Jan 16, 2025

Wiz Scan Summary

Scanner Findings
Data Finding Sensitive Data 1 Low
Secret Finding Secrets
IaC Misconfiguration IaC Misconfigurations
Total 1 Low

View scan details in Wiz

To detect these findings earlier in the dev lifecycle, try using Wiz Code VS Code Extension.

@live-github-bot live-github-bot bot removed the screenshots Screenshots have been updated label Jan 16, 2025
Justkant
Justkant previously approved these changes Jan 16, 2025
@live-github-bot
Copy link
Contributor Author

live-github-bot bot commented Jan 16, 2025

Desktop Bundle Checks

Comparing 430b544 against 7802de4.

⚠️ renderer bundle size significantly increased: 37.8mb -> 38mb. Please check if this is expected.

Mobile Bundle Checks

Comparing 430b544 against 79489d7.

⚠️ main.ios.jsbundle bundle size significantly increased: 61.8mb -> 62mb. Please check if this is expected.
⚠️ main.android.jsbundle bundle size significantly increased: 61.8mb -> 62mb. Please check if this is expected.

@KVNLS KVNLS merged commit 5ab951d into develop Jan 16, 2025
54 of 55 checks passed
@KVNLS KVNLS deleted the support/release-merge-conflicts branch January 16, 2025 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli common Has changes in live-common desktop Has changes in LLD ledgerjs Has changes in the ledgerjs open source libs mobile Has changes in LLM translations Translation files have been touched ui Has changes in the design system library
Projects
None yet
Development

Successfully merging this pull request may close these issues.