test/add-workflow-for-cli-account-management-and-data-sync #9001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 4 Skipped Deployments
|
apps/ledger-live-desktop/tests/specs/speculos/ledgerSync.spec.ts
Outdated
Show resolved
Hide resolved
apps/ledger-live-desktop/tests/specs/speculos/ledgerSync.spec.ts
Outdated
Show resolved
Hide resolved
apps/ledger-live-desktop/tests/specs/speculos/ledgerSync.spec.ts
Outdated
Show resolved
Hide resolved
apps/ledger-live-desktop/tests/specs/speculos/ledgerSync.spec.ts
Outdated
Show resolved
Hide resolved
| test.describe(`[${app.name}] Sync Accounts`, () => { | ||
| const ledgerKeyRingProtocolArgs = { | ||
| pubKey: "", | ||
| privateKey: "", | ||
| }; | ||
|
|
||
| const ledgerSyncPushDataArgs = { |
There was a problem hiding this comment.
Consolidate redundant logic like setting ledgerKeyRingProtocolArgs and ledgerSyncPullDataArgs.
apps/ledger-live-desktop/tests/specs/speculos/ledgerSync.spec.ts
Outdated
Show resolved
Hide resolved
apps/ledger-live-desktop/tests/specs/speculos/ledgerSync.spec.ts
Outdated
Show resolved
Hide resolved
| ...LedgerSyncCliHelper.ledgerSyncPullDataArgs, | ||
| }); | ||
|
|
||
| let parsedData = typeof pulledData === "string" ? JSON.parse(pulledData) : pulledData; |
There was a problem hiding this comment.
let's move data parsing to a separate method in utils class, also let's make sure to handle potential JSON parse errors
try {
parsedData = typeof pulledData === "string" ? JSON.parse(pulledData) : pulledData;
} catch (error) {
throw new Error(`Failed to parse pulledData: ${error.message}`);
}
| } | ||
|
|
||
| static async initializeLedgerSync() { | ||
| const output = CLI.ledgerKeyRingProtocol({ |
There was a problem hiding this comment.
I feel like await is missing here, wdyt?
static async initializeLedgerSync() {
const output = await CLI.ledgerKeyRingProtocol({
getKeyRingTree: true,
...LedgerSyncCliHelper.ledgerKeyRingProtocolArgs,
});
LedgerSyncCliHelper.updateKeysAndArgs(output);
await activateLedgerSync();
return output;
}
VicAlbr
reviewed
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ Checklist
npx changesetwas attached.📝 Description
This test aims to:
❓ Context
https://ledgerhq.atlassian.net/browse/LIVE-15537
🧐 Checklist for the PR Reviewers