Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix: NFTs transactions filtered from spam TXs #9355

Open
wants to merge 17 commits into
base: develop
Choose a base branch
from
Open

bugfix: NFTs transactions filtered from spam TXs #9355

wants to merge 17 commits into from
+883 −518

Conversation

mcayuelas-ledger
Copy link
Contributor

@mcayuelas-ledger mcayuelas-ledger commented Feb 26, 2025 •
edited by jira bot
Loading

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

📝 Description

  • Add empty state on HiddenCollections Screens
  • Filter NFTs operation from History

❓ Context

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@vercel Vercel
Copy link

vercel bot commented Feb 26, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Feb 28, 2025 5:44pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Feb 28, 2025 5:44pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Feb 28, 2025 5:44pm
web-tools ⬜️ Ignored (Inspect) Visit Preview Feb 28, 2025 5:44pm

@live-github-bot live-github-bot bot added desktop Has changes in LLD mobile Has changes in LLM translations Translation files have been touched labels Feb 26, 2025
@mcayuelas-ledger mcayuelas-ledger marked this pull request as ready for review February 27, 2025 16:42
@mcayuelas-ledger mcayuelas-ledger requested a review from a team as a code owner February 27, 2025 16:42
themooneer
themooneer previously approved these changes Feb 27, 2025
View reviewed changes
Copy link
Contributor

@themooneer themooneer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM FF ON/OFF

themooneer
themooneer previously approved these changes Feb 28, 2025
View reviewed changes
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
0.4% Coverage on New Code (required ≥ 80%)
5.2% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

themooneer
themooneer previously approved these changes Feb 28, 2025
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgrellard-ledger cgrellard-ledger cgrellard-ledger approved these changes

@themooneer themooneer themooneer left review comments

Assignees

@mcayuelas-ledger mcayuelas-ledger

Labels
desktop Has changes in LLD mobile Has changes in LLM translations Translation files have been touched
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mcayuelas-ledger @themooneer @cgrellard-ledger