Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(TranslatedError): fallback if "message" is missing #9358

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

fix(TranslatedError): fallback if "message" is missing #9358

wants to merge 1 commit into from
+6 −3

Conversation

valpinkman
Copy link
Member

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

📝 Description

Fix for TranslatedError in LLD when dealing with DMK errors

https://ledger.sentry.io/issues/6334135193/?project=6488660

❓ Context

  • JIRA or GitHub link:

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@valpinkman valpinkman requested a review from a team as a code owner February 26, 2025 14:39
@live-github-bot live-github-bot bot added the desktop Has changes in LLD label Feb 26, 2025
@vercel Vercel
Copy link

vercel bot commented Feb 26, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Feb 26, 2025 2:47pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Feb 26, 2025 2:47pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Feb 26, 2025 2:47pm
web-tools ⬜️ Ignored (Inspect) Visit Preview Feb 26, 2025 2:47pm

@valpinkman valpinkman force-pushed the bugfix/live-dmk-no-error-message branch from d09f8d6 to 80801cb Compare February 26, 2025 14:43
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@valpinkman valpinkman added this pull request to the merge queue Feb 26, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KVNLS KVNLS KVNLS approved these changes

Assignees

@valpinkman valpinkman

Labels
desktop Has changes in LLD
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@valpinkman @KVNLS