Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📈 (llm) enhance reborn analytics #9379

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

Conversation

LucasWerey
Copy link
Contributor

@LucasWerey LucasWerey commented Feb 27, 2025

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • onboarding
    • reborn

📝 Description

Add a new selector isReborn to track if the user is in reborn and if he has a device during the onboarding.
(Schema bellow is a quick representation since there is specific flow depending of the device etc )

image

❓ Context


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@LucasWerey LucasWerey requested review from a team as code owners February 27, 2025 15:06
Copy link

vercel bot commented Feb 27, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Feb 27, 2025 3:10pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Feb 27, 2025 3:10pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Feb 27, 2025 3:10pm
web-tools ⬜️ Ignored (Inspect) Visit Preview Feb 27, 2025 3:10pm

@live-github-bot live-github-bot bot added the mobile Has changes in LLM label Feb 27, 2025
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
22.2% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@LucasWerey LucasWerey marked this pull request as draft February 27, 2025 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do not review mobile Has changes in LLM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant