Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate HAVE_MCU_SERIAL_STORAGE flag code #836

Merged
merged 1 commit into from
Jan 2, 2025

Conversation

nroggeman-ledger
Copy link
Contributor

Description

The goal of this PR is to Integrate and remove HAVE_MCU_SERIAL_STORAGE (always defined) flag.
This is a PR of code cleaning.
It is not planned to support products or flavors without this feature, so the flag is useless (it was defined only for Nanos but it was a mistake, because available on all products)

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Tests
  • Documentation
  • [*] Other (for changes that might not fit in any category)

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 35.49%. Comparing base (b1727b3) to head (299ed47).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #836   +/-   ##
=======================================
  Coverage   35.49%   35.49%           
=======================================
  Files          13       13           
  Lines        1606     1606           
=======================================
  Hits          570      570           
  Misses       1036     1036           
Flag Coverage Δ
unittests 35.49% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nroggeman-ledger nroggeman-ledger merged commit a2be76c into master Jan 2, 2025
189 checks passed
@nroggeman-ledger nroggeman-ledger deleted the integrate-HAVE_MCU_SERIAL_STORAGE-flag branch January 2, 2025 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants