Incrementing spinner Use Case when called multiple times #849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nroggeman-ledger
requested review from
yogh333,
cedelavergne-ledger and
tdejoigny-ledger
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #849 +/- ##
=======================================
Coverage 60.43% 60.43%
=======================================
Files 13 13
Lines 1820 1820
=======================================
Hits 1100 1100
Misses 720 720
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
nroggeman-ledger
force-pushed
the
incrementing-spinner-use-case
branch
from
46da5f5 to
b81cfce
Compare
yogh333
approved these changes
Jan 30, 2025
nroggeman-ledger
force-pushed
the
incrementing-spinner-use-case
branch
from
b81cfce to
0638813
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The goal of this PR is to implement the ability to call nbgl_useCaseSpinner() several time in a raw. It enables to "turn" the corner, for example when used in some steps of a long mono-process, preventing the automatic update.
Changes include