Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incrementing spinner use case #850

Merged
merged 1 commit into from
Jan 30, 2025

Conversation

nroggeman-ledger
Copy link
Contributor

Description

The goal of this PR is to implement the ability to call nbgl_useCaseSpinner() several time in a raw. It enables to "turn" the corner, for example when used in some steps of a long mono-process, preventing the automatic update.
This is a cherry-pick on API LEVEL 22

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Tests
  • Documentation
  • Other (for changes that might not fit in any category)

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (API_LEVEL_22@dc8127e). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff               @@
##             API_LEVEL_22     #850   +/-   ##
===============================================
  Coverage                ?   83.02%           
===============================================
  Files                   ?        9           
  Lines                   ?      483           
  Branches                ?        0           
===============================================
  Hits                    ?      401           
  Misses                  ?       82           
  Partials                ?        0           
Flag Coverage Δ
unittests 83.02% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nroggeman-ledger nroggeman-ledger merged commit 8a9c943 into API_LEVEL_22 Jan 30, 2025
181 checks passed
@nroggeman-ledger nroggeman-ledger deleted the incrementing-spinner-use-case_22 branch January 30, 2025 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants