Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement resolution of selectors #122

Merged
merged 4 commits into from
Oct 28, 2024
Merged

Conversation

jnicoulaud-ledger
Copy link
Contributor

No description provided.

@jnicoulaud-ledger jnicoulaud-ledger requested a review from a team as a code owner October 28, 2024 13:01
Copy link
Contributor

@fsamier fsamier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

linter code can be slightly simplified as a similar logic was also implemented

@jnicoulaud-ledger
Copy link
Contributor Author

jnicoulaud-ledger commented Oct 28, 2024

Indeed I copied it from there initially 🤦 Note there is a small regression with this PR, since we lose the function signature information in resolved form, linter messages are slightly less informative. We could add the function signature back as a separate field in resolved form, but not done in this PR

@jnicoulaud-ledger jnicoulaud-ledger enabled auto-merge (squash) October 28, 2024 13:41
@jnicoulaud-ledger jnicoulaud-ledger merged commit fa72361 into main Oct 28, 2024
5 checks passed
@jnicoulaud-ledger jnicoulaud-ledger deleted the resolve-selector branch October 28, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants