fix(template): typo of jinja2 minus and package name #12
Conversation
"ensurepath" seems non-existent and also not used. Besides, the minus of endif should not remove the preceding space of invoke.
|
This site will help you try different jinja2 minus syntax http://jinja.quantprogramming.com/ It's useful for me to confirm the typo. |
| @@ -24,8 +24,7 @@ git checkout -b [YOUR FEATURE] | |||
|
|
|||
| ```sh | |||
| python -m pip install pipx | |||
| python -m pipx install {% if cookiecutter.dependency_management_tool == 'pipenv' -%}pipenv{%- elif cookiecutter.dependency_management_tool == 'poetry' -%}poetry{% endif -%} invoke | |||
| python -m pipx ensurepath | |||
There was a problem hiding this comment.
Do you mean this line is not necessary? But in the documentation of pipx, it seems to be needed if you use it for the first time.
There was a problem hiding this comment.
oops, it seems that I misunderstood something. Let me re-walk through the whole process to confirm its dependency. Thanks for the feedback!
There was a problem hiding this comment.
hmmm I have no luck to install poetry with pipx.
ubuntu-mate 18.04 shows
$ pipx --version
0.16.0.0
$ pipx install poetry
No apps associated with package poetry or its dependencies. If you are attempting to install a library,
pipx should not be used. Consider using pip or a similar tool instead.
Would you mind showing me your output of pipx --version and pipx install poetry?
There was a problem hiding this comment.
hmmm... interesting
This how it looks like when I install it through pipx.
$ pipx --version
0.15.5.1
$ pipx install poetry
⚠️ Note: poetry was already on your PATH at ....../.pyenv/shims/poetry
installed package poetry 1.1.4, Python 3.8.5
These apps are now globally available
- doesitcache
- poetry
- virtualenv
done! ✨ 🌟 ✨
It works even after I upgrade pipx to 0.16.0.0
There was a problem hiding this comment.
@tai271828 Is there any update on this one?
There was a problem hiding this comment.
No, QQ. I did not work on this anymore. It's in my wish list of task. Feel free to close the pull request.
There was a problem hiding this comment.
No worries 🙂 Let's make it a draft one so that I know I don't need to review it at this moment.
There was a problem hiding this comment.
Sounds good! Draft is a good idea so we could keep the track.
Yeah I have had dug into this issue and found it is a rabbit hole : (
This one is awesome!!! Wish I know it earlier. Thanks for your sharing! |
Lee-W
force-pushed
the
master
branch
2 times, most recently
from
73cb2c2
to
f86de41
Compare
"ensurepath" seems non-existent and also not used. Besides, the minus of endif should not remove the preceding space of invoke.