better backbutton #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this allows us to easily switch between languages and even go back multiple questions
|
So I tested it locally and it seemed to work fine, but once merged into master it seems to not work properly on the web. For now I've reverted the merge. |
|
hmm not worked properly as in? |
|
tried it on a fork and seems to work fine, did take like a few minutes to update tho |
|
@zeratax In my experience (using Google Chrome), the results error out, with all axes displaying as 50% no matter how the questions are answered. Additionally, it seems it is not possible to go back to the first question after getting to the second question. |
|
oh yeah same for me with firefox, I'll look at that tomorrow. was that the same when you merged it to master? |
|
Yeah, the same issues occurred. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
!closes #13
Everything gets saved into a cookie that looks like this:
and expires after 1 hour.
switching between languages or reloading now also won't reset your currently entered questions.
After answering the last question or waiting one hour everything should be reset again.
it should also now be fairly easy to instead of decrementing or incrementing to do #6
I don't have tested this much