Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 fix getAngle for motor groups #20

Merged
merged 1 commit into from
Feb 3, 2025
Merged

🐛 fix getAngle for motor groups #20

merged 1 commit into from
Feb 3, 2025

Conversation

toxicdefender404
Copy link
Contributor

@toxicdefender404 toxicdefender404 commented Jan 31, 2025 •
edited
Loading

getSize tries to claim the mutex which is already claimed by getAngle causing a deadlock

Download the template for this pull request:

Note

This is auto generated from Add Template to Pull Request

curl -o [email protected]+39214b.zip https://nightly.link/LemLib/hardware/actions/artifacts/2519451072.zip;
pros c fetch [email protected]+39214b.zip;
pros c apply [email protected]+39214b;
rm [email protected]+39214b.zip;

@toxicdefender404 toxicdefender404 changed the title fix getAngle for motor groups 🐛 fix getAngle for motor groups Jan 31, 2025
SizzinSeal
SizzinSeal approved these changes Feb 3, 2025
View reviewed changes
Copy link
Member

@SizzinSeal SizzinSeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SizzinSeal SizzinSeal merged commit 295841b into LemLib:main Feb 3, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SizzinSeal SizzinSeal SizzinSeal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@toxicdefender404 @SizzinSeal