Add dummy .sh files for .dsv hooks #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjsowa
force-pushed
the
bugfix/hooks-not-working
branch
from
8cbe777 to
5b130ff
Compare
bjsowa
requested changes
Nov 7, 2024
|
@Mergifyio backport iron humble |
✅ Backports have been created
|
This was referenced Nov 8, 2024
bjsowa
pushed a commit
that referenced
this pull request
Nov 8, 2024
* Add dummy .sh files for .dsv hooks * Add back .in extension to worlds hook (cherry picked from commit 4b66204) Co-authored-by: Jan Hernas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building packages with ament_package
.dsvfiles are not taken in properly unless there is a.shfile with the same name registered withament_environment_hooks. This is not the case when building the package withcolcon. This PR adds dummy.shfile so the the hooks work as expected under all circumstances.