Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/MIDAZ-349 #355

Merged
merged 4 commits into from
Dec 3, 2024
Merged

Feature/MIDAZ-349 #355

merged 4 commits into from
Dec 3, 2024

Conversation

qnen
Copy link
Contributor

@qnen qnen commented Dec 2, 2024

Midaz Pull Request Checklist

Pull Request Type

  • Auth
  • Infra
  • Ledger
  • Mdz
  • Transaction
  • Pipeline
  • Documentation

Checklist

Please check each item after it's completed.

  • I have tested these changes locally.
  • I have updated the documentation accordingly.
  • I have added necessary comments to the code, especially in complex areas.
  • I have ensured that my changes adhere to the project's coding standards.
  • I have checked for any potential security issues.
  • I have ensured that all tests pass.
  • I have updated the version appropriately (if applicable).
  • I have confirmed this code is ready for review.

Additional Notes

Obs: Please, always remember to target your PR to develop branch instead of main.

@qnen qnen added feature New feature domain:onboarding Responsible for the initial configuration of the ledger domain:portfolio Responsible for creating accounts labels Dec 2, 2024
@qnen qnen self-assigned this Dec 2, 2024
@qnen qnen requested a review from a team as a code owner December 2, 2024 22:08
@qnen qnen linked an issue Dec 2, 2024 that may be closed by this pull request
Copy link

what-the-diff bot commented Dec 2, 2024

PR Summary

  • Enhanced Clarity in Repository Methods
    We've updated the naming convention of arguments in the repository methods to be more descriptive for better understanding and consistency.

  • Repository Method Renaming
    The method previously known as FindAll has been renamed to FindAllWithDeleted. This change better communicates the function's purpose — retrieving both active and soft-deleted assets in the database.

  • New Package Constant Addition
    We've introduced a new constant for external account alias prefix in the package. This will enhance consistency and readability.

  • System-wide Change in Repository Method Usage
    The newly renamed method FindAllWithDeleted has been implemented across various files. This ensures consistent and correct retrieval of all assets, including deleted ones, throughout the application.

  • Improved Error Handling and Deletion Logic
    Added robust logic for deleting external accounts in addition to better error handling when deleting an asset. This minimizes application errors and provides a more stable solution.

@qnen qnen merged commit 42940b2 into develop Dec 3, 2024
7 checks passed
@lerian-studio-midaz-push-bot
Copy link

🎉 This PR is included in version 1.31.0-beta.7 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain:onboarding Responsible for the initial configuration of the ledger domain:portfolio Responsible for creating accounts feature New feature released on @develop
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement soft delete on the Asset deletion endpoint
3 participants