Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding useful type-class instances for NonEmpty #689

Closed
wants to merge 1 commit into from
Closed

Adding useful type-class instances for NonEmpty #689

wants to merge 1 commit into from

Conversation

recursion-ninja
Copy link

Pull Request to address #688 .

@recursion-ninja recursion-ninja force-pushed the instances-for-NonEmpty branch from 3b5517a to dd7c600 Compare April 20, 2024 18:43
LeventErkok
LeventErkok requested changes Apr 20, 2024
View reviewed changes
Copy link
Owner

@LeventErkok LeventErkok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The OrdSymbolic instance doesn’t look correct to me. Can you double check?

Also: Stylewise, I don’t patenthesize the classes to the left of => if there’s only one of them, if you don’t mind.

@LeventErkok
Copy link
Owner

I'll add an implementation that correctly does the ord instance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LeventErkok LeventErkok LeventErkok requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@recursion-ninja @LeventErkok