Docker: Use host port 8080 instead of 80 #182
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes life easier for a developer with port 80 already in use. Docker is used only in development - this does not affect production installations. Signed-off-by: Marko Lindqvist <[email protected]>
Is there anybody who would be affected by such a negative way? If nobody is objecting this, I hope it to get merged soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is something that I would want to make my own work easier. I have regular webserver on port 80, so I have to carry this change locally at least - and a couple of times I've lost a lot of time because I had missed it and FCW build failed in the final steps of taking the ports to use.
I know that other people without port 80 in use could argue that this is a step back for them.
In any case, this does not affect production, as FCW does not use docker there.