-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dev #197
Open
Lexxie9952
wants to merge
2,161
commits into
master
Choose a base branch
from
dev
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Dev #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
some were 21px high and some 20px high causing "fissures" and slight height anomalies
all changes here should be as guides for making new styles later
Lexxie9952
added a commit
that referenced
this pull request
Mar 22, 2024
Reported that it would only play silent break repeatedly. Somehow pick_next_track() was getting called before a tracklist_init() was called.
…p-click), ... 1. Linux users get ctrl-shift-T for trade routes because ctrl-alt-T launches a terminal for them. 2. Add alternate help-click in PREFS for alt-shift click, allows Linux and possibly others to change meta-click to alt-shift-click to get help on anything. 3. Create abstraction layer for reprogramming alternate metaclicks anywhere in the game, metaKey(e) instead of e.metaKey. Use it to implement the above. 4. Create FIREFOX warning in help landing page and a link to an article explaining how to fix Firefox settings from not highjacking ctrl-shift and alt-shift clicks with its own unwanted context menu stuff.
have to keep up with attack strength inflation for all the other foot units
Fix occurrence of democracy wrongly documented as going into anarchy when a city is in disorder two turns ... change to "more than two turns". NB: Changed all occurrences and translations of such in freeciv fandom also. Including normal classic ruleset which was misdocumented there.
… trumped by rule 7.
Make more clear whether build succeeded or failed. Prevents cases where changes to code don't happen while testing executable, because unseen build failure and then using last good executable.
... as JS client currently can't evaluate EFT_HAVE_EMBASSIES because it lacks effects evaluation like that native client has.
…er order Most often called during recursive ZOC/pathfinding so it should check tile_is_seen() first, because it's less expensive and 95% of the tile can_player_see_city_internals is true, the tile is already seen. Also inline will make it faster.
chmod -x by default
green/red for OK/Down results
Fix wrong label of Have_Contacts effect.
Use recently renamed build scripts without hyphens instead of old names
Add CLI documentation for how to checkout dev branch
Clarify: 1. Multipass is now best way to set up VM 2. Vagrant scripts don't auto install python 3.7 3. Clone from dev branch, change given CLI commands. 4. Warn about ``--depth 1`` argument doesn't work. other misc
Hopefully last step in fixing an install issue referring to deprecated and soon-to-deprecate rulesets from failing during a basic install after VM setup.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
merge with dev