Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Method for nested Div and List #8

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

raouldandresy
Copy link

IMPORTANT: for a right use of nested list it's mandatory to use just Div and not Table like Wrapper.

@raouldandresy
Copy link
Author

@andreasrosdal Thank you for the right suggestion :)

@asturio
Copy link
Member

asturio commented Apr 4, 2024

@raouldandresy @andreasrosdal
Sorry for not having merge this before. My attentions are normally focused in OpenPDF, when I have it. The PR is a little more than 3 years old, which is quite a long time.

I'm not a fan of reflection, but not sure what are the implications of this PR. The only think I see there, is that you are only managing 1 level of nesting here. Maybe that is ok.

Are you still using OpenPDF5? Is this still important?

Opinions?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants