Skip to content
This repository has been archived by the owner on Oct 21, 2022. It is now read-only.

Removed FS dependency #51

Merged
merged 1 commit into from
Sep 3, 2015
Merged

Removed FS dependency #51

merged 1 commit into from
Sep 3, 2015

Conversation

tonsky
Copy link
Contributor

@tonsky tonsky commented Aug 29, 2015

lein-light-nrepl used to depend on fs library. This library is unstable (they change public API all too often), and is used in other projects (figwheel, lein-cljsbuild). It was a source of great pain (bhauman/lein-figwheel#119, bhauman/lein-figwheel#11, LightTable/LightTable#1482, bhauman/devcards#14).

Turned out it was not crucial to have this lib as a dependency. It was used rarely and for pretty trivial stuff. So I just removed it.

@kenny-evitt
Copy link

@cldwalker @rundis This looks reasonable; thoughts?

@kenny-evitt
Copy link

@tonsky Thanks for the changes

@rundis
Copy link
Contributor

rundis commented Aug 31, 2015

👍
Nice to get rid of that pesky dependency regardless of whether we go down the route of inlining deps in the middleware or not.

@cldwalker
Copy link
Member

Good eye @tonsky! Ideally we'd like to solve dependencies with a general solution like #48. But this seems reasonable in the meantime. Whomever merges please QA effected behaviors

@cldwalker cldwalker merged commit 1b5a00f into LightTable:master Sep 3, 2015
@kenny-evitt kenny-evitt removed the ready label Sep 3, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants