This repository has been archived by the owner on Oct 21, 2022. It is now read-only.
Changed eval-on-save function to handle external browser connections. #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also: this bug persists in the CSS plugin, so the same code would be applied there. |
|
I'm not able to reproduce the bug when opening any html file or just a new file and setting it to html syntax. Can you describe the steps required to reproduce this? The issue I suspect we need to address is the editor being nil. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Had the same problem as detailed here in LightTable issue #1309 and found the default editor is
#<Atom: nil>when connected to an external browser. So far this fix has worked for me.Thoughts?