chore: add photon with multiple trees tests #1198
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement TreeFinder for asynchronous tree discovery and insertion. Update EpochManager to handle new trees and integrate this process within the service. Configure tree discovery intervals to ensure continuous updates.
Enhanced the logging in `add_new_tree` function to improve traceability and added checks to ensure trees are only processed during the active phase. Adjusted test configurations and timing to stabilize test execution under photon.
sergeytimoshin
force-pushed
the
jorrit/add-photon-tests
branch
from
902ae3d to
8a92b33
Compare
ananas-block
force-pushed
the
jorrit/add-photon-tests
branch
from
2a67eae to
3f542f8
Compare
ananas-block
force-pushed
the
jorrit/add-photon-tests
branch
from
26f730e to
d94a21b
Compare
vadorovsky
reviewed
Sep 12, 2024
| merkle_tree_pubkey: Pubkey::new_from_array(decode_hash(&x.tree)), | ||
| leaf_index: x.leaf_index.try_into().unwrap(), | ||
| queue_index: None, | ||
| nullifier_queue_pubkey: Pubkey::default(), //env_accounts.nullifier_queue_pubkey, // TODO: make dynamic. Why don't we get this value from the rpc call? |
There was a problem hiding this comment.
I think the correct approach here would be fetching the MT account and checking the associated queue. We could consider caching the results in a local hashmap, to avoid RPC calls for literally every indexer call. Do you agree? That's what I'm trying right now on my side.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: