feat: batch address mt #1365
Merged
feat: batch address mt #1365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ananas-block
changed the base branch from
jorrit/feat-bloomfilter-queues
to
sergey/batch-address-update-rebased-fixed
ananas-block
changed the base branch from
sergey/batch-address-update-rebased-fixed
to
jorrit/test-rebase-audit-branch
ananas-block
changed the base branch from
jorrit/test-rebase-audit-branch
to
feat/batched-trees
ananas-block
commented
Dec 4, 2024
ananas-block
commented
Dec 4, 2024
feat: forester clears bloom filter feat: insert zkp batch feat: read only address
ananas-block
force-pushed
the
jorrit/feat-batch-address-mt
branch
from
434f4a1 to
cdb92dd
Compare
ananas-block
force-pushed
the
jorrit/feat-batch-address-mt
branch
from
5d8bf22 to
9ba56ac
Compare
ananas-block
requested review from
SwenSchaeferjohann and
sergeytimoshin
as code owners
ananas-block
force-pushed
the
jorrit/feat-batch-address-mt
branch
from
b0a0ff4 to
e0d3175
Compare
ananas-block
added a commit
that referenced
this pull request
Dec 10, 2024
* fix: stop zeroing out commitments proven by inclusion * feat: batch address tree feat: forester clears bloom filter feat: insert zkp batch feat: read only address * test: add tests and format * add readonly account tests * start refactor read only accounts * feat: read only accounts * fix: proof by index check in system program * refactor: tx hash
sergeytimoshin
pushed a commit
that referenced
this pull request
Dec 13, 2024
* fix: stop zeroing out commitments proven by inclusion * feat: batch address tree feat: forester clears bloom filter feat: insert zkp batch feat: read only address * test: add tests and format * add readonly account tests * start refactor read only accounts * feat: read only accounts * fix: proof by index check in system program * refactor: tx hash
ananas-block
added a commit
that referenced
this pull request
Dec 16, 2024
* fix: stop zeroing out commitments proven by inclusion * feat: batch address tree feat: forester clears bloom filter feat: insert zkp batch feat: read only address * test: add tests and format * add readonly account tests * start refactor read only accounts * feat: read only accounts * fix: proof by index check in system program * refactor: tx hash
ananas-block
added a commit
that referenced
this pull request
Dec 17, 2024
* fix: stop zeroing out commitments proven by inclusion * feat: batch address tree feat: forester clears bloom filter feat: insert zkp batch feat: read only address * test: add tests and format * add readonly account tests * start refactor read only accounts * feat: read only accounts * fix: proof by index check in system program * refactor: tx hash
sergeytimoshin
added a commit
that referenced
this pull request
Dec 19, 2024
* fix: add light prover client batch update and append tests added bloomfilter batch e2e test failing because filter change doesn't work yet debugging batched Merkle tree e2e test works with output queue fix: e2e test work with input and output queues chore: rename wipe bloomfilter -> wipe_batch refactored input queue into mt account stash test: rnd account init works chore: replace is_inserted with state chore: moved offset to bounded vec, added bounded vec init and deserialize fixed bounded vec imports refactor: partial batch zkp updates, flexible sized root history array with seq implemented batch prove and verification in rust tests untested stash: batched updates work with simulate transactions test add comment stash before account *mut onchain account init works test: account compression program batch updates work feat: add flexbile nullifier to circuit feat: implement nullifier derivation from tx hash test: batch test: bounded vec cleanup cleanup cleanup feat: add flexible nullifier to update circuit fix: e2e test chore: add full asserts to simulate tx test test: root overwrite test cleanup * refactor: update health check timeout in spawn_prover function, rewrite prove_batch_append test Change CI runner to buildjet-8vcpu-ubuntu-2204 for rust tests run rust.yml on buildjet-16vcpu-ubuntu-2204 debug rust.yml workflow Add step to download proving keys for big batches Remove redundant setup steps and update test configurations Update ProverConfig to use test-specific circuits cleaning up after rebase to main * fix: batch append public input computation (#1330) Issue: the batch append zkp public input LeavesHashchainHash is computed dynamically from the values array during the batched update. If the values array changes in between proof generation and transaction execution the batched append update fails. -> Users can make batched append update transactions fail. Solution: compute LeavesHashchainHash incrementally when the output value is inserted into the value array (the same way we compute it with nullifiers for input queue insertions). Changes: 1. switch to updated circuits 2. batch.rs - add start_index field to derive the leaf_index of values from a value array - introduce store_and_hash_value to store an output queue value and add it to the LeavesHashchainHash 3. batched_queue.rs - init_queue initialize start_index during account initialization - use store_and_hash_value instead of store_value when inserting into output queues - update batch.start_index when wiping a batch 4. batched_merkle_tree.rs - remove subtree field (it is not used in new batch append circuit) - initialize root_history with the zero_value_root - add hashchain store for leaves_hashchain in ZeroCopyBatchedMerkleTreeAccount - add leaf_index to nullifier hash H(value, leaf_index, tx_hash) Co-authored-by: ananas-block <[email protected]> * feat: integrate batched state merkle trees into programs (#1335) * fix: rebase * feat: rollover state trees (#1371) * feat: rollover batch state trees * test: batch state tree rollover * feat: batch address mt (#1365) * fix: stop zeroing out commitments proven by inclusion * feat: batch address tree feat: forester clears bloom filter feat: insert zkp batch feat: read only address * test: add tests and format * add readonly account tests * start refactor read only accounts * feat: read only accounts * fix: proof by index check in system program * refactor: tx hash * perf: unify circuit public inputs Issue: - public inputs consume too many CU onchain Impacted Circuits: - inclusion - non-inclusion - combined Changes: - make existing public inputs private - hash public inputs into one hash chain - make hash chain the only public input * chore: refactor batched trees and merkle tree metadata into separate crates * feat: add proving keys for mt 32 (#1406) * feat: add support for circuits with height 32 and update related tests * chore: remove combined_32_0_0 verifying key file * refactor: remove deprecated verifying keys, restore inclusin_26_*.rs vkeys * refactor: prover: integration tests for mt 32 * refactor: generate_keys.sh * fix: bounded vec mut deserialization from immutable reference * feat: add migrate state instruction * fix: tests * fix: lint * fix: system cpi tests * fix: tests * cleanup --------- Co-authored-by: Sergey Timoshin <[email protected]> Co-authored-by: ananas-block <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.