Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove anchor dependency in js #1415

Open
wants to merge 19 commits into
base: main
Choose a base branch
from
Open

chore: remove anchor dependency in js #1415

wants to merge 19 commits into from
+2,722 −10,629

Conversation

SwenSchaeferjohann
Copy link
Contributor

@SwenSchaeferjohann SwenSchaeferjohann commented Dec 22, 2024 •
edited
Loading

problem:
some consumers use old solana versions (1.73.5) + prefer smaller bundle size

  • add support for 1.73.5+
  • removes anchor dependency in stateless.js and compressed-token
  • removes idl dependency in js sdks
  • reduces bundle size 5mb -> 2.5mb
  • testrpc should be used with typecasting only. not relevant for consumers
  • bumps internal web3js use to latest, v1.98.0

todo

  • look into further size optimization and making the es browser bundle accessible
  • public release

@SwenSchaeferjohann SwenSchaeferjohann marked this pull request as ready for review December 27, 2024 15:54
@SwenSchaeferjohann SwenSchaeferjohann marked this pull request as draft December 27, 2024 15:55
@SwenSchaeferjohann SwenSchaeferjohann marked this pull request as ready for review December 27, 2024 17:58
@SwenSchaeferjohann
pin js sdks to use [email protected]
7ba6eef 
wip

remove anchor from stateless.js

add buffer-layout.dt.ts

add note

wip

wip

remove anchor dep in ctoken

use bs58

fmt

wip

remove custom program id test

fix dl keyss

statelessjs bundle optimization. remove idls

rm tweetnacl, minify compressed-token lib

wip. less externals

wip: try alpha

npm release script with alpha option

wip

wip

stateless.js works with web3js 1.73.5 - alpha

wip
@SwenSchaeferjohann
Copy link
Contributor Author

ready for first pass

ananas-block
ananas-block reviewed Jan 5, 2025
View reviewed changes
Copy link
Contributor

@ananas-block ananas-block left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice it's more contained than I thought. A couple small things, and more tests would be great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sergeytimoshin sergeytimoshin Awaiting requested review from sergeytimoshin sergeytimoshin is a code owner

@ananas-block ananas-block Awaiting requested review from ananas-block ananas-block is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SwenSchaeferjohann @ananas-block