-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat : 소셜링 검색결과 필터링 구현 #58
Merged
The head ref may contain hidden characters: "9-be-\uC18C\uC15C\uB9C1-\uAC80\uC0C9\uACB0\uACFC-\uD544\uD130\uB9C1-\uAD6C\uD604"
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
jsilver01
reviewed
Aug 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
요약 (Summary)
🔑 변경 사항 (Key Changes)
GetSocialringSearchFilterRequest/Response dto 작성
: 소셜링 검색결과 필터링에 필요한 dto를 작성했습니다.SocialringService.searchFilterSocialring 작성
: 소셜링 검색결과 필터링 서비스를 작성했습니다.SocialringController.searchFilterSocialring 작성
: 소셜링 검색결과 필터링 컨트롤러를 작성했습니다.SocialringRepository.findAllByStatus 작성
: 모든 소셜링을 반환하기 위해 관련 레포지토리 작성했습니다.📝 리뷰 요구사항 (To Reviewers)
확인 방법
코드를 실행시키고,mysql workbench에서 다음 쿼리문을 실행시켜주세요.
member 중 하나는 리뷰자의 정보로 수정해야합니다.
그 다음 카카오 소셜 로그인을 해주세요.
https://kauth.kakao.com/oauth/authorize?client_id=220ac935aaf5aa43884ee21823d82237&redirect_uri=http://localhost:8080/auth/kakao/callback&response_type=code
엑세스토큰을 postman에 넣고 테스트 해주세요
다음 주소로 GET 요청 보내주세요
http://localhost:8080/socialring/search/filter
request body는 다음과 같이 구성됩니다.
첫번째 요청을 보냈을때 배구이면서 성별이 F , 모집정원인원이 0~9 사이인 소셜링 아이디는 2,3이기때문에 위와같은 결과가 나와야합니다!
소셜링1은 축구이면서 모집인원이 10명이라 필터링되야합니다!
두번째 요청을 보냈을때 성별이 F, 모집정원인원이 6이상인 소셜링 아이디가 1,2이기때문에 위와같은 결과가 나와야합니다!
소셜링3은 모집정원인원이 5라 필터링되야합니다!
세번째 요청을 보냈을때 생성된 소셜링은 성별이 모두F이기때문에 해당하는 소셜링이없으므로 위와같은 예외처리가 나온다면 성공입니다!