Jason depp patch 20240801 #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rewrite code statement to make it more clear for future enhancement - reorganize target verification and unit verification - remove unit nil verification before setting local variables name and realm because it's already done ahead - add comments
the CallbackHandler should come in before LibDataBroker and LibDBIcon because of dependencies, otherwise the addon can not load. (test with this single addon living, turn off the rest)
|
Looking good to me. Makes sense to merge the if statements for easier readability. I refrained from altering the existing code while integrating the new Blizzard Menu into the retail version, hoping it would also be implemented in the classic versions, but it appears that will not happen. I'm currently at my day job, so I'm unable to test it right now, but i will merge the changes. |
|
Thanks. do we have another channel to chat... |
|
You can contact on Discord. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Limmek,
could you please review my updates and approve the pull request.
I know it's just tiny changes that I should report and let yourself update, consider this as a first time cooperation or a dry run.
if it works, then I can do more work in the future.
Thanks in advance.