New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set unique_id before passing it to entity_id #150

Merged

Limych merged 1 commit into Limych:dev from chris-y:entityid

May 2, 2024

Contributor

chris-y commented Apr 12, 2024

Proposed change

Fix entity_id so it doesn't show up as sensor.unnamed_device
This only appears to affect new entries - existing ones keep the old entity_id

Type of change

Dependency upgrade
Bugfix (non-breaking change which fixes an issue)
New feature (which adds functionality to an this integration)
Breaking change (fix/feature causing existing functionality to break)
Code quality improvements to existing code or addition of tests

Additional information

This PR fixes or closes issue: fixes Entity shows up as sensor.unnamed_device, should have canonical name #148

Checklist

The code change is tested and works locally.
There is no commented out code in this PR.
The code has been formatted using Black (black --fast custom_components)

If user exposed functionality or configuration variables are added/changed:

Documentation added/updated to README.md


          Set unique_id before passing it to entity_id

270452a

Limych merged commit 6e0ad35 into Limych:dev

10 checks passed

Owner

Limych commented May 2, 2024

Thanks ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet