Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsilver01
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
요약 (Summary)
🔑 변경 사항 (Key Changes)
- leaveStudyroom : 더티체킹 활용하도록 save메서드를 지우고, 일부 로직을 정리했습니다.
- getStudyroomDetail : 이전에는 필요한 것만 select 했었는데, 확장에도 닫혀있고, 쓰려면 레포지토리 코드를 봐야한다는 점에서 비효율적이라고 판단하여 패치조인으로 수정했습니다.
-MemberstudyroomRepository : getStudyroomDetail 을 패치조인으로 수정하였습니다!
📝 리뷰 요구사항 (To Reviewers)